bug in rcmail_save_passwd()

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug in rcmail_save_passwd()

mk-19
Hi,

        Not sure if this is a known issue. I found my rc installation unable to
change email accounts passwords in the db. A short digging revealed that the
mysql query uses wrong variable.

$newpasswd vs. $newpassword (line 44 and 48)

Changing $newpasswd to $newpassword fixes the issue. This is version
roundcubemail-0.1-rc1.1.

Second issue is that there is polish translation missing for texts
like 'change password' etc.

I checked this via www interface and it says nothing is missing.

Anyway I added them manually.

BTW. Nice work.

Thanks.
_______________________________________________
List info: http://lists.roundcube.net/dev/
Reply | Threaded
Open this post in threaded view
|

Re: bug in rcmail_save_passwd()

Raoul Bhatia [IPAX]
hi mk,

[hidden email] wrote:
> Not sure if this is a known issue. I found my rc installation unable to
> change email accounts passwords in the db. A short digging revealed that the
> mysql query uses wrong variable.
 >
 > $newpasswd vs. $newpassword (line 44 and 48)
 >
 > Changing $newpasswd to $newpassword fixes the issue. This is version
 > roundcubemail-0.1-rc1.1.

since when is it possible to change the password via the default
roundcube install?

i know that there is a patch lurking around somewhere, but i haven't
seen it in the official svn, nor does trac.roundecube.net find anything.

> Second issue is that there is polish translation missing for texts
> like 'change password' etc.
>
> I checked this via www interface and it says nothing is missing.
>
> Anyway I added them manually.

as the password change feature is not in the official roundcube
repository, why should the translations be in there? :)

i think we can discard these issues as they are related to a
third-party-patch.

cheers,
raoul bhatia
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc.          email.          [hidden email]
Technischer Leiter

IPAX - Aloy Bhatia Hava OEG         web.          http://www.ipax.at
Barawitzkagasse 10/2/2/11           email.            [hidden email]
1190 Wien                           tel.               +43 1 3670030
FN 277995t HG Wien                  fax.            +43 1 3670030 15
____________________________________________________________________
_______________________________________________
List info: http://lists.roundcube.net/dev/
Reply | Threaded
Open this post in threaded view
|

Re: bug in rcmail_save_passwd()

mk-19
> > Not sure if this is a known issue. I found my rc installation unable to
> > change email accounts passwords in the db. A short digging revealed that
> > the mysql query uses wrong variable.
> >
>  > $newpasswd vs. $newpassword (line 44 and 48)
>  >
>  > Changing $newpasswd to $newpassword fixes the issue. This is version
>  > roundcubemail-0.1-rc1.1.
>
> since when is it possible to change the password via the default
> roundcube install?
>
> i know that there is a patch lurking around somewhere, but i haven't
> seen it in the official svn, nor does trac.roundecube.net find anything.

Ho...hm ... true. I patched it but thought the bug was in the unpatched
version.

> > Second issue is that there is polish translation missing for texts
> > like 'change password' etc.
> >
> > I checked this via www interface and it says nothing is missing.
> >
> > Anyway I added them manually.
>
> as the password change feature is not in the official roundcube
> repository, why should the translations be in there? :)
>
> i think we can discard these issues as they are related to a
> third-party-patch.

Sorry for the noise.

Thanks.
_______________________________________________
List info: http://lists.roundcube.net/dev/