upgrade to php 7.3

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

upgrade to php 7.3

Andreas Meyer
Hello!

Today I upgraded from php 5.x to php 7.3 and removed php 5.x completly. Now I found I get a blank screen
calling roundcube.

I then added
error_reporting(E_ALL);
ini_set('display_errors', 'On');

and get
Notice: Undefined index: env in /usr/share/roundcubemail/index.php on line 46
Notice: Undefined variable: rcmail_config in /usr/share/roundcubemail/program/lib/Roundcube/rcube_config.php on line 325
Notice: Undefined offset: 2 in /usr/share/roundcubemail/program/lib/Roundcube/rcube_charset.php on line 223

Is there a way to fix this? Should I install roundcube form scratch?

--
Kind regards

  Andreas

_______________________________________________
Roundcube Users mailing list
[hidden email]
http://lists.roundcube.net/mailman/listinfo/users

attachment0 (235 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: upgrade to php 7.3

Andreas Meyer
Reindl Harald <[hidden email]> schrieb am 30.07.19 um 14:16:43 Uhr:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
>
>
> Am 30.07.19 um 13:49 schrieb Andreas Meyer:
> > Today I upgraded from php 5.x to php 7.3 and removed php 5.x
> > completly. Now I found I get a blank screen calling roundcube.
> >
> > I then added error_reporting(E_ALL); ini_set('display_errors',
> > 'On');
> >
> > and get Notice: Undefined index: env in
> > /usr/share/roundcubemail/index.php on line 46 Notice: Undefined
> > variable: rcmail_config in
> > /usr/share/roundcubemail/program/lib/Roundcube/rcube_config.php on
> > line 325 Notice: Undefined offset: 2 in
> > /usr/share/roundcubemail/program/lib/Roundcube/rcube_charset.php on
> > line 223
> >
> > Is there a way to fix this? Should I install roundcube form
> > scratch?  
>
> you probably did something else than just replace the PHP binaries
>
> we are currently on PHP 7.2 because 7.3 is far from production ready
> when trivial code like below recently was broken no matter that we
> have proper autotests for a 250000 LOC codebase which runs perfectly
> with 7.3 and 7.4 HEAD
>
> so i would not be suprised that you hit a similar or this bug
>
> /** https://bugs.php.net/bug.php?id=78271 */
> function bug78271($a, $b)
> {
>  if($a==10)
>  {
>   $w = "x";
>  }
>  else
>  {
>   $w = "y";
>  }
>  if($b)
>  {
>   $d1 = "none";
>   $d2 = "block";
>  }
>  else
>  {
>   $d1 = "block";
>   $d2 = "none";
>  }
>  return $d2.$b;
> }
> if(bug78271(1, 1) !== 'block1')
> {
>  trigger_error('https://bugs.php.net/bug.php?id=78271');
>  $exit_code = 1;
> }
>
> why don't you learn to build packages for roundcube and PHP combined
> with proper backups of your document roots so that you can upgrade and
> downgrade and reinstall everything in a clean way?
But wait, on one server with CentOS 7 on which roundcube runs fine I have

$ php -v
PHP 7.3.7 (cli) (built: Jul  3 2019 11:30:22) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.7, Copyright (c) 1998-2018 Zend Technologies
    with the ionCube PHP Loader + ionCube24 v10.3.7, Copyright (c) 2002-2019, by ionCube Ltd.
    with Zend OPcache v7.3.7, Copyright (c) 1999-2018, by Zend Technologies

and on the server (I installed php 7.3 today) I get a blank screen

# php -v
PHP 7.3.7 (cli) (built: Jul  3 2019 11:30:22) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.7, Copyright (c) 1998-2018 Zend Technologies

I also changed <IfModule mod_php5.c> to <IfModule mod_php7.c> in the .htaccess
of roundcube but that did not change anything.

--
  Andreas

_______________________________________________
Roundcube Users mailing list
[hidden email]
http://lists.roundcube.net/mailman/listinfo/users

attachment0 (235 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: upgrade to php 7.3

Andreas Meyer
Reindl Harald <[hidden email]> schrieb am 30.07.19 um 16:03:22 Uhr:

> > $ php -v PHP 7.3.7 (cli) (built: Jul  3 2019 11:30:22) ( NTS )
> > Copyright (c) 1997-2018 The PHP Group Zend Engine v3.3.7, Copyright
> > (c) 1998-2018 Zend Technologies with the ionCube PHP Loader +
> > ionCube24 v10.3.7, Copyright (c) 2002-2019, by ionCube Ltd. with
> > Zend OPcache v7.3.7, Copyright (c) 1999-2018, by Zend Technologies
> >
> > and on the server (I installed php 7.3 today) I get a blank screen
> >
> > # php -v PHP 7.3.7 (cli) (built: Jul  3 2019 11:30:22) ( NTS )
> > Copyright (c) 1997-2018 The PHP Group Zend Engine v3.3.7, Copyright
> > (c) 1998-2018 Zend Technologies
> >
> > I also changed <IfModule mod_php5.c> to <IfModule mod_php7.c> in
> > the .htaccess of roundcube but that did not change anything.  
>
> well, don't you see the differences?
got it now

# php -v
PHP 7.3.8 (cli) (built: Jul 30 2019 09:26:16) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.8, Copyright (c) 1998-2018 Zend Technologies
    with the ionCube PHP Loader + ionCube24 v10.3.7, Copyright (c) 2002-2019, by ionCube Ltd.
    with Zend OPcache v7.3.8, Copyright (c) 1999-2018, by Zend Technologies


>
> one is using *two* bytecode caches (bad idea)
> the other don't run one at all
>
> they can make subtle differences in good and bad ways
>
> anyways, this is as so often not a roudcube issue so go and find out
> the differences and consider some sort of config management instead of
> run randomly different setups spread all over your machines
>
> upgrading from a random PHP5 version directly to 7.3 is pretty dumb as
> you miss all the warnings and deprecation notices between minor
> versions and specially 5 to 7 and didn't likely clean up your stuff
> over the years
>
> shopuldn't be a problem with roundcube but you are running 3rd party
> stuff given all the issues you had in the past years nobody else had
I have it running. Started the installer again and saw there where some
dependencies for php7.3 missing not ok. Installed them and didn't need
to install roundcube again. Can login, the blank screen (500 server error)
is gone.

All is well. Thanks!

--
  Andreas


_______________________________________________
Roundcube Users mailing list
[hidden email]
http://lists.roundcube.net/mailman/listinfo/users

attachment0 (235 bytes) Download Attachment